Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 31, 2021

Bumps @types/node from 12.12.67 to 12.20.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot requested a review from a team as a code owner March 31, 2021 22:07
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Mar 31, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 31, 2021

Us: *tries to limit @types/node from updating. Thinks next check won't come for a bit
Dependabot:

image

@jawnsy
Copy link

jawnsy commented Mar 31, 2021

@jsjoeio lol it's technically doing what we're asking, just not what we want... 😂

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 31, 2021

LOL I know I know... I just thought it might take a little break, ya know? Maybe wait a day before opening anotha' one.

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 31, 2021

Going to test node v12.20.2 to make sure everything works as expected with code-server. (thought the types would line up with node versions, but they don't AFAICT, so use 12.20.2.

@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 31, 2021

image

I think this is okay. And I think we'll be able to update the actual version in package.json and remove the resolutions line.
https://github.com/cdr/code-server/blob/main/package.json#L75

@jsjoeio jsjoeio merged commit 6207a31 into main Mar 31, 2021
@jsjoeio jsjoeio deleted the dependabot/npm_and_yarn/types/node-12.20.7 branch March 31, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants